[PATCH] D123803: [WIP][llvm] A Unified LTO Bitcode Frontend

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 15 10:43:17 PDT 2022


mehdi_amini added inline comments.


================
Comment at: llvm/lib/Passes/PassBuilder.cpp:1144
+      if (!PTO.UnifiedLTO)
+        MPM.addPass(buildThinLTODefaultPipeline(L, nullptr));
+      else
----------------
It is concerning to me that we add one mode different code path / behavior to maintain instead of unifying everything.

If UnifiedLTO is able to use the LTO pipeline effectively, what would be the reason for ThinLTO to not align?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123803/new/

https://reviews.llvm.org/D123803



More information about the llvm-commits mailing list