[PATCH] D123264: [RISCV] Pre-RA expand pseudos pass

[luxufan via Phabricator via llvm-commits]

StephenFan added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVExpandPseudoInsts.cpp:454
+  Symbol.setTargetFlags(FlagsHi);
+  MCSymbol *AUIPCSymbol = MF->getContext().createTempSymbol("PCRelHi");
+
----------------
Using `createTempSymbol` to create a symbol will cause the object code's string table to have an empty name for the symbol. Maybe you could use the `MF.getPICBaseSymbol()` function to create the PIC base symbol. It can create the function local symbol by using the unique function id.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123264/new/

https://reviews.llvm.org/D123264