[PATCH] D121984: [RISCV] Moving RVV intrinsic type related util to clang/Support

Kito Cheng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 15 07:00:04 PDT 2022


kito-cheng added a comment.

> Thank you for the explanation. I still don't think this is really "Support" material, but I'm also struggling to think of a better place to put it in an existing directory in Clang aside from Basic, but that would still be a bit of a layering violation it feels like. So I think I'm convinced that Support is a reasonable place to put it.

Actually I tried to put that on clang/Basic before, and end up with the clang/Basic is depended on clang-tblgen, and that made clang-tblgen depend on clang/Basic...then CMake report error for circular dependency :P

> Should it live within a RISCV direction inside of the Support directory? Or should we use folders like that for host platform support files instead of target platform support files (as the LLVM Support directory appears to do)?

I saw LLVM/Support are just target specific file on the folder instead of many target folder, I guess there should not be too much target specific files in clang/Support, and we could reorg the folder organization once it getting complicated? What do you think?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121984/new/

https://reviews.llvm.org/D121984



More information about the llvm-commits mailing list