[PATCH] D123363: [SelectionDAG] Update emission of udivmodei5 to latest ABI changes

Fri Apr 15 05:22:15 PDT 2022

LuoYuanke added inline comments.

================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp:3927

+  unsigned WordSizeInBits = DAG.getLibInfo().getIntSize();
+
----------------
What's the word size in bit? 16 or 32? Int looks double word size.

================
Comment at: llvm/test/CodeGen/X86/udivmodei5.ll:1103
 ; X64:       # %bb.0:
-; X64-NEXT:    subq $200, %rsp
+; X64-NEXT:    subq $280, %rsp # imm = 0x118
 ; X64-NEXT:    andl $1, %r9d
----------------
Why stack increase 80 for the new API? Doesn't it only increase 4 bytes for the extra space of a?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123363/new/

https://reviews.llvm.org/D123363