[PATCH] D123779: [AArch64] Add `foldOverflowCheck` DAG combine

[Paul Walker via Phabricator via llvm-commits]

paulwalker-arm added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:15435
+static Optional<AArch64CC::CondCode> getCSETCondCode(SDValue Op) {
+  if (Op.getOpcode() == AArch64ISD::CSEL) {
+    auto CC = static_cast<AArch64CC::CondCode>(Op.getConstantOperandVal(2));
----------------
paulwalker-arm wrote:
> LLVM coding standard prefers early exits, so this should be
> ```
> if (Op.getOpcode() == AArch64ISD::CSEL)
>   return None;
Or rather
```
if (Op.getOpcode() != AArch64ISD::CSEL)
  return None;
```

:)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123779/new/

https://reviews.llvm.org/D123779