[PATCH] D123834: [PGO] Remove legacy PM passes

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 14 21:41:58 PDT 2022


MaskRay created this revision.
MaskRay added reviewers: aeubanks, davidxl, nikic, xur.
Herald added subscribers: ormris, StephenFan, wenlei, kerbowa, hiraditya, jvesely.
Herald added a reviewer: ctetreau.
Herald added a reviewer: ctetreau.
Herald added a reviewer: ctetreau.
Herald added a reviewer: ctetreau.
Herald added a project: All.
MaskRay requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Legacy PM was deprecated in 13.0.0 and Clang dropped legacy PM support in
D123609 <https://reviews.llvm.org/D123609>. This change removes legacy PM passes for PGO so that downstream
projects won't be able to use it.
It seems appropriate to start removing such "add-on" features like
instrumentations, before we remove more stuff after 15.x is branched.

I have checked many LLVM users and only ldc[1] uses the legacy PGO pass.

[1]: https://github.com/ldc-developers/ldc/issues/3961


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D123834

Files:
  llvm/include/llvm/InitializePasses.h
  llvm/include/llvm/LinkAllPasses.h
  llvm/include/llvm/Transforms/IPO/PassManagerBuilder.h
  llvm/include/llvm/Transforms/Instrumentation.h
  llvm/lib/Transforms/IPO/PassManagerBuilder.cpp
  llvm/lib/Transforms/Instrumentation/IndirectCallPromotion.cpp
  llvm/lib/Transforms/Instrumentation/Instrumentation.cpp
  llvm/lib/Transforms/Instrumentation/PGOInstrumentation.cpp
  llvm/lib/Transforms/Instrumentation/PGOMemOPSizeOpt.cpp
  llvm/test/CodeGen/AMDGPU/opt-pipeline.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D123834.423019.patch
Type: text/x-patch
Size: 26204 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220415/060884b5/attachment-0001.bin>


More information about the llvm-commits mailing list