[PATCH] D123290: [LoongArch] Add support for selecting constant materializations.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 14 17:41:36 PDT 2022


MaskRay added a comment.

Is it necessary to have the 4483 line test? To cover all the code paths in the function, it is possible to use significantly fewer tests.



================
Comment at: llvm/lib/Target/LoongArch/MCTargetDesc/LoongArchMatInt.h:29
+} // namespace llvm
+#endif
----------------
Add one blank line before the header guard `#endif`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123290/new/

https://reviews.llvm.org/D123290



More information about the llvm-commits mailing list