[PATCH] D123821: [llvm-objcopy][NFC] refactor restoreStatOnFile out of llvm-objcopy.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 14 14:31:52 PDT 2022


MaskRay added a comment.

> Functionality of restoreStatOnFile may be reused.

Do you have an impending usage? The functionality is to emulate in-place update of GNU strip/objcopy where "copy" in "objcopy" assumes some "cp" like behavior.

For many utilities, they probably shouldn't do this.



================
Comment at: llvm/include/llvm/Support/FileUtilities.h:127
+
+  protected:
+    FilePermissionsCarrier(StringRef InputFilename, sys::fs::file_status Status)
----------------
private?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123821/new/

https://reviews.llvm.org/D123821



More information about the llvm-commits mailing list