[PATCH] D123809: [AMDGPU] Pre-checkin updated lit tests for D123525.

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/agpr-usage-should-fail-on-gfx900.ll:1
+; RUN: not llc -march=amdgcn -mcpu=gfx900 -verify-machineinstrs < %s 2>&1 | FileCheck -check-prefixes=GFX900 %s
+
----------------
I do not see why do you need to split it and for that matter this test is too complicated for a simple check that 'a' constraint is not accepted. It was OK as a side check, but not as a separate test.


================
Comment at: llvm/test/CodeGen/AMDGPU/spill-agpr-gfx908.ll:1
-; RUN: llc -march=amdgcn -mcpu=gfx908 -verify-machineinstrs < %s | FileCheck -enable-var-scope -check-prefixes=GCN,GFX908 %s
-; RUN: llc -march=amdgcn -mcpu=gfx90a -verify-machineinstrs < %s | FileCheck -enable-var-scope -check-prefixes=GCN,GFX90A %s
+; RUN: llc -march=amdgcn -mcpu=gfx908 -verify-machineinstrs < %s | FileCheck -enable-var-scope -check-prefixes=GFX908 %s
 
----------------
Again, why split it? It is the same test. If you need an extra function with 6 vgprs just add it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123809/new/

https://reviews.llvm.org/D123809