[PATCH] D123628: [InstCombine] Bail on memrchr calls with an excessive size.

[Nikita Popov via Phabricator via llvm-commits]

nikic accepted this revision.
nikic added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/Transforms/Utils/SimplifyLibCalls.cpp:906
+
   return nullptr;
 }
----------------
nikic wrote:
> msebor wrote:
> > xbolva00 wrote:
> > > But currently this patch does not make sense a bit as we would reach this nullptr (with your patch we reach it sooner).
> > > 
> > > So in the current form, I dont think we need this patch. This “bail out” you can add in the patch which uses this patch as a base.
> > The follow-on patch depends on this hunk so now that they've both been reviewed and agreed on, whether they're applied separately or together doesn't seem important.  But they're easy enough to merge before committing.
> Yeah, this makes more sense as part of the next patch in the stack now.
Right. The code change itself is fine, so I'm marking this as approved.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123628/new/

https://reviews.llvm.org/D123628