[PATCH] D122270: Support converting pointers from opaque to typed

[Chris Bieneman via Phabricator via llvm-commits]

beanz added a comment.

@nhaehnle sorry, I realized this patch hadn't been rebased since the request to just fork the full bitcode writer.

The reason I add a "PrefixType" in the ValueEnumerator is because the ValueEnumerator's constructor does a module walk and registers types. Because Types can't be referenced out of order in the bitcode, I need to make sure to shove in the `i8*` type at the beginning.

My latest update to this patch keeps that behavior even though the full ValueEnumerator is forked, but with it forked I think there is a better solution I can implement to have it insert the pointer types in the right place, and move the `PointerTypeMap` into the ValueEnumerator (which probably makes more sense anyways).

I'll work on reworking this patch over the next day or two, but may not get an update uploaded until I get back from vacation on 4/25.

Thank you!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122270/new/

https://reviews.llvm.org/D122270