[PATCH] D123678: [polly] migrate -polly-show to the new pass manager

[Michael Kruse via Phabricator via llvm-commits]

Meinersbur added inline comments.


================
Comment at: polly/lib/Support/RegisterPasses.cpp:333-340
-  if (PollyViewer)
-    PM.add(polly::createDOTViewerPass());
-  if (PollyOnlyViewer)
-    PM.add(polly::createDOTOnlyViewerPass());
-  if (PollyPrinter)
-    PM.add(polly::createDOTPrinterPass());
-  if (PollyOnlyPrinter)
----------------
The legacy pass manger is till present and people are still using it (which includes me). That is, the old functionality should not be removed, especially without giving any notification (such as `report_fatal_error` as with the NPM).

In other places, common code was extracted into a separate function such as `runSimplifyUsingNPM` or wrapper passes provided. Could you do the same?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123678/new/

https://reviews.llvm.org/D123678