[PATCH] D123811: [ObjCARC] Drop nullary clang.arc.attachedcall bundles in autoupgrade.

[Ahmed Bougacha via Phabricator via llvm-commits]

ab created this revision.
ab added reviewers: ahatanak, fhahn.
Herald added subscribers: dexonsmith, hiraditya.
Herald added a reviewer: apazos.
Herald added a project: All.
ab requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

This was originally part of D118214 <https://reviews.llvm.org/D118214>, and was removed because we didn't know of situations where the post-arc-contract nullary bundle ends up in bitcode.  Turns out this does happen, with swiftc -embed-bitcode!

  In certain use-cases, these can be emitted by old compilers, but the
  operand is now always required.  These are only used for optimizations,
  so it's safe to drop them if they happen to have the now-invalid format.
  The semantically-required call is already a separate instruction.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D123811

Files:
  llvm/include/llvm/IR/AutoUpgrade.h
  llvm/lib/Bitcode/Reader/BitcodeReader.cpp
  llvm/lib/IR/AutoUpgrade.cpp
  llvm/test/Bitcode/upgrade-arc-attachedcall-bundle.ll
  llvm/test/Bitcode/upgrade-arc-attachedcall-bundle.ll.bc

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D123811.422935.patch
Type: text/x-patch
Size: 4044 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220414/1e1c45f0/attachment.bin>