[PATCH] D123010: [asan] Emit .size directive for global object size before redzone

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 14 10:56:01 PDT 2022


MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.

Please wait for a sanitizer reviewer (@vitalybuka) to confirm this is fine.



================
Comment at: llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp:695
+    if (const MDNode *ExplicitValue = GV->getMetadata("explicit_size")) {
+      assert(ExplicitValue->getNumOperands() &&
+             "Should have been checked by verifier allready");
----------------
Omit this: getOperand(0) has an `assert`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123010/new/

https://reviews.llvm.org/D123010



More information about the llvm-commits mailing list