[PATCH] D123010: [asan] Emit .size directive for global object size before redzone

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/test/Verifier/explicit_size.ll:2
+; RUN: split-file %s %t
+; RUN: not llc < %t/multiple.ll -mtriple=x86_64-unknown-linux-gnu 2>&1 | FileCheck %s --check-prefix=MULTIPLE
+; RUN: not llc < %t/operands.ll -mtriple=x86_64-unknown-linux-gnu 2>&1 | FileCheck %s --check-prefix=OPERANDS
----------------
This directory doesn't use `llc`. You can verify by looking for other tests.

Use `opt -verify -disable-output `


================
Comment at: llvm/test/Verifier/explicit_size.ll:9
+;--- multiple.ll
+ at a = global i64 0, align 8, !explicit_size !0, !explicit_size !0
+
----------------
As mentioned, an aggregate type makes more sense and should be tested


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123010/new/

https://reviews.llvm.org/D123010