[PATCH] D123525: [AMDGPU] On gfx908, reserve VGPR for AGPR copy based on register budget.

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIFrameLowering.cpp:1279
+      FuncInfo->setVGPRForAGPRCopy(UnusedLowVGPR);
+      MRI.freezeReservedRegs(MF);
+    }
----------------
Do we have to freeze it here?


================
Comment at: llvm/test/CodeGen/AMDGPU/agpr-copy-no-free-registers.ll:1093
 ; GFX90A-NEXT:    s_waitcnt vmcnt(0)
-; GFX90A-NEXT:    v_accvgpr_write_b32 a11, v39            ;  Reload Reuse
-; GFX90A-NEXT:    v_accvgpr_write_b32 a12, v38            ;  Reload Reuse
-; GFX90A-NEXT:    v_accvgpr_write_b32 a13, v37            ;  Reload Reuse
-; GFX90A-NEXT:    v_accvgpr_write_b32 a14, v36            ;  Reload Reuse
-; GFX90A-NEXT:    v_accvgpr_write_b32 a15, v35            ;  Reload Reuse
+; GFX90A-NEXT:    v_accvgpr_write_b32 a11, v39 ; Reload Reuse
+; GFX90A-NEXT:    v_accvgpr_write_b32 a12, v38 ; Reload Reuse
----------------
Could you please pre-commit changes like that?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123525/new/

https://reviews.llvm.org/D123525