[PATCH] D123750: [ELF][AArch64] Fix unneeded thunk for branches to hidden undefined weak

[Peter Smith via Phabricator via llvm-commits]

peter.smith accepted this revision.
peter.smith added a comment.
This revision is now accepted and ready to land.

LGTM. One small suggestion for the comment.



================
Comment at: lld/ELF/Arch/AArch64.cpp:260
+  // be resolved as a branch to the next instruction. If it is hidden, its
+  // binding has been converted to local, so we just check isUndefined() here. A
+  // undefined non-weak symbol has been errored.
----------------
Nit: `An undefined non-weak symbol will have been errored.`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123750/new/

https://reviews.llvm.org/D123750