[PATCH] D123629: [InstCombine] Fold memrchr calls with a constant character.

[Nikita Popov via Phabricator via llvm-commits]

nikic accepted this revision.
nikic added a comment.
This revision is now accepted and ready to land.

LG apart from test nits.



================
Comment at: llvm/test/Transforms/InstCombine/memrchr-3.ll:151
   %ptr = getelementptr [5 x i8], [5 x i8]* @a12345, i32 0, i32 1
   %ret = call i8* @memrchr(i8* %ptr, i32 5, i64 4)
   ret i8* %ret
----------------
Should pass `1` here to match test description.


================
Comment at: llvm/test/Transforms/InstCombine/memrchr-3.ll:185
+define i8* @fold_memrchr_a12345_3_n(i64 %n) {
+; CHECK-LABEL: @fold_memrchr_a12345_3_n(
+;
----------------
Missing check lines?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123629/new/

https://reviews.llvm.org/D123629