[PATCH] D116464: [SPIRV 5/6] Add LegalizerInfo, InstructionSelector and utilities
Ilia Diachkov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Apr 14 04:52:23 PDT 2022
iliya-diyachkov added a comment.
Thanks, Renato!
> First, sorry for the confusion if I made you do something only to revert later, but that shows the value of multi-person reviews. So, also thanks others for picking up on that.
No problem. The initial version of macros was more complicated, so it was not just a return, but an adaptation of the original code.
Now we have to finish the review of the 6th patch <https://reviews.llvm.org/D116465>. All the issues were fixed about a week ago, I hope Matt will respond soon.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116464/new/
https://reviews.llvm.org/D116464
More information about the llvm-commits
mailing list