[PATCH] D123699: [AMDGPU] Remove redundand RequiredAlignment assignment. NFCI.

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 14 01:24:14 PDT 2022


foad accepted this revision.
foad added a comment.
This revision is now accepted and ready to land.

Thanks!



================
Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:1553
 
       // 12 byte accessing via ds_read/write_b96 require 16-byte alignment on
       // gfx8 and older.
----------------
Not sure why the comment mentions gfx8. Even on later archs the requirement is for 16-byte alignment **if** you set strict alignment mode.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123699/new/

https://reviews.llvm.org/D123699



More information about the llvm-commits mailing list