[PATCH] D123505: Mips/GlobalISel: Add stub post-legalizer combiner

Simon Dardis via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 13 14:48:04 PDT 2022


sdardis accepted this revision.
sdardis added a comment.
This revision is now accepted and ready to land.

LGTM with the nit addressed.



================
Comment at: llvm/lib/Target/Mips/CMakeLists.txt:4
 set(LLVM_TARGET_DEFINITIONS Mips.td)
+tablegen(LLVM MipsGenGlobalISel.inc -gen-global-isel)
+tablegen(LLVM MipsGenPostLegalizeGICombiner.inc -gen-global-isel-combiner
----------------
Nit: this change should preserve the existing ordering, i.e. just add the new line after the tablegen usage for MipsGenGlobalISel.inc.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123505/new/

https://reviews.llvm.org/D123505



More information about the llvm-commits mailing list