[PATCH] D123735: llvm-reduce: Fix asserting on undef virtual registers

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 13 14:31:13 PDT 2022


arsenm created this revision.
arsenm added reviewers: lebedev.ri, aeubanks, markus, aemerson, reames, paquette.
Herald added a project: All.
arsenm requested review of this revision.
Herald added a subscriber: wdng.
Herald added a project: LLVM.

This was only populating the virtual register map for def operands
that appeared in the function, but that may not exist if there are
only undef uses.


https://reviews.llvm.org/D123735

Files:
  llvm/test/tools/llvm-reduce/mir/undef-virt-reg.mir
  llvm/tools/llvm-reduce/ReducerWorkItem.cpp


Index: llvm/tools/llvm-reduce/ReducerWorkItem.cpp
===================================================================
--- llvm/tools/llvm-reduce/ReducerWorkItem.cpp
+++ llvm/tools/llvm-reduce/ReducerWorkItem.cpp
@@ -35,7 +35,7 @@
     for (auto &SrcMI : SrcMBB) {
       for (unsigned I = 0, E = SrcMI.getNumOperands(); I < E; ++I) {
         auto &DMO = SrcMI.getOperand(I);
-        if (!DMO.isReg() || !DMO.isDef())
+        if (!DMO.isReg())
           continue;
         Register SrcReg = DMO.getReg();
         if (Register::isPhysicalRegister(SrcReg))
Index: llvm/test/tools/llvm-reduce/mir/undef-virt-reg.mir
===================================================================
--- /dev/null
+++ llvm/test/tools/llvm-reduce/mir/undef-virt-reg.mir
@@ -0,0 +1,20 @@
+# REQUIRES: amdgpu-registered-target
+# RUN: llvm-reduce -mtriple=amdgcn-amd-amdhsa --test FileCheck --test-arg --check-prefix=CHECK-INTERESTINGNESS --test-arg %s --test-arg --input-file %s -o %t 2> %t.log
+# RUN: FileCheck --match-full-lines --check-prefix=RESULT %s < %t
+
+# CHECK-INTERESTINGNESS: S_NOP 0
+
+# RESULT: S_ENDPGM 0, implicit undef %0:vgpr_32
+
+# Previously the the function clone would assert due to not preserving
+# virtual registers which had no defs.
+
+---
+name: undef_vreg_operand
+tracksRegLiveness: true
+body:             |
+  bb.0:
+    S_NOP 0
+    S_ENDPGM 0, implicit undef %0:vgpr_32
+
+...


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D123735.422653.patch
Type: text/x-patch
Size: 1397 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220413/ec92ebda/attachment.bin>


More information about the llvm-commits mailing list