[PATCH] D123626: [InstCombine] Fold memrchr calls with constant size of zero or one.

Martin Sebor via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 13 12:52:45 PDT 2022


msebor added inline comments.


================
Comment at: llvm/test/Transforms/InstCombine/memrchr-3.ll:91
 define i8* @fold_memrchr_ax_c_1(i32 %0) {
 ; CHECK-LABEL: @fold_memrchr_ax_c_1(
+; CHECK-NEXT:    [[MEMRCHR_CHAR0:%.*]] = load i8, i8* getelementptr inbounds ([0 x i8], [0 x i8]* @ax, i64 0, i64 0), align 1
----------------
xbolva00 wrote:
> nit: please also set some names to parameters to avoid %0, %1, etc..
> 
Sure, let me do that separately: rGb8bac957d18b.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123626/new/

https://reviews.llvm.org/D123626



More information about the llvm-commits mailing list