[PATCH] D118299: [Spill2Reg][2/9] This patch adds spill/reload collection.

[Guozhi Wei via Phabricator via llvm-commits]

Carrot added inline comments.
Herald added a subscriber: StephenFan.
Herald added a project: All.


================
Comment at: llvm/lib/CodeGen/Spill2Reg.cpp:79
+  /// Look for candidates for spill2reg. These candidates are in places with
+  /// high memoru unit contention. Fills in StackSlotData.
+  void collectSpillsAndReloads();
----------------
typo 'memoru'


================
Comment at: llvm/lib/Target/X86/X86InstrInfo.cpp:9489
+bool X86InstrInfo::isLegalToSpill2Reg(unsigned MemBits, unsigned Opcode) const {
+  switch (Opcode) {
+  // Skip instructions like `$k1 = KMOVWkm %stack.1` because replacing stack
----------------
Instead of checking opcode, it's better to check register class.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118299/new/

https://reviews.llvm.org/D118299