[PATCH] D120286: AMDGPU: Don't use unreachable on stores to unhandled address space

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added a comment.

In D120286#3449116 <https://reviews.llvm.org/D120286#3449116>, @dyung wrote:

> Hi @arsenm, the test you added is failing on our internal linux build bot that builds a release build without asserts with the following error:
>
>   Command Output (stderr):
>   --
>   /home/dyung/src/upstream/llvm_clean_git/llvm/test/CodeGen/AMDGPU/store-to-constant-error.ll:4:9: error: SDAG: expected string not found in input
>   ; SDAG: LLVM ERROR: Cannot select: t{{[0-9]+}}: ch = store<(store (s32) into %ir.ptr.load, addrspace 4)>
>           ^
>   <stdin>:1:1: note: scanning from here
>   LLVM ERROR: Cannot select: 0x55f05ad6f228: ch = store<(store (s32) into %ir.ptr.load, addrspace 4)> 0x55f05acd7d38, Constant:i32<1>, 0x55f05ad6f020, undef:i64
>   ^
>
> Can you take a look?

This is because the nodes in the debug output change from numbered notes to raw pointers in release builds


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120286/new/

https://reviews.llvm.org/D120286