[PATCH] D123343: [AMDGPU] Refactor LDS alignment checks.

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 13 11:20:55 PDT 2022


rampitec marked an inline comment as done.
rampitec added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:1555
       // gfx8 and older.
-      bool AlignedBy16 = Alignment >= Align(16);
-      if (IsFast)
-        *IsFast = AlignedBy16;
+      RequiredAlignment = Align(16);
+      break;
----------------
rampitec wrote:
> foad wrote:
> > You don't need this - it is already handled by using PowerOf2Ceil to initialize RequiredAlignment.
> Indeed.
D123699


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123343/new/

https://reviews.llvm.org/D123343



More information about the llvm-commits mailing list