[PATCH] D122251: [lit] Use sharding for GoogleTest format

Wed Apr 13 10:58:51 PDT 2022

ldionne added a comment.

In D122251#3446908 <https://reviews.llvm.org/D122251#3446908>, @rprichard wrote:

> In D122251#3446881 <https://reviews.llvm.org/D122251#3446881>, @ychen wrote:
>
>> In D122251#3446870 <https://reviews.llvm.org/D122251#3446870>, @rprichard wrote:
>>
>>>     File "/x/llvm-upstream/llvm-project/libcxx/utils/libcxx/test/dsl.py", line 80, in _executeScriptInternal
>>>       litConfig = lit.LitConfig.LitConfig(
>>>   TypeError: __init__() missing 1 required positional argument: 'order'
>>
>> Fixed in 81b51b61f849fa91bdf5d069591 <https://reviews.llvm.org/rG81b51b61f849fa91bdf5d0695918578abae846e3>
>
> Thanks, looks fixed to me.

Yup, thanks. And sorry @ychen for this piece of tech debt that we carry around in libc++. I'll try removing it in the future when/if I get some time.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122251/new/

https://reviews.llvm.org/D122251