[PATCH] D122987: [OpenMP] Make offloading sections have the SHF_EXCLUDE flag

Wed Apr 13 09:31:45 PDT 2022

jhuber6 added inline comments.

================
Comment at: llvm/include/llvm/MC/SectionKind.h:27

+    /// Exclude - This section will be excluded from the final executable or
+    /// shared library.
----------------
MaskRay wrote:
> https://llvm.org/docs/CodingStandards.html#doxygen-use-in-documentation-comments "Don’t duplicate function or class name at the beginning of the comment."
> 
> It may help to add "(ELF specific)".
Yes, this only works for COFF and ELF so that should probably be documented. As for the style I'm just keeping it consistent with what's already here. I could make a follow-up patch to clean it but I figured it would add unnecessary noise to this one.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122987/new/

https://reviews.llvm.org/D122987