[PATCH] D123496: Add Stackmap support for RISC-V

Alex Bradbury via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 13 08:58:24 PDT 2022


asb added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:9529
+  case TargetOpcode::STATEPOINT:
+    if (Subtarget.is64Bit())
+      report_fatal_error(
----------------
I think you mean `!Subtarget.is64Bit()`?


================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:9531
+      report_fatal_error(
+          "STACKMAP, PATCHPOINT and STATEPOINT are only to be used on riscv64");
+    return emitPatchPoint(MI, BB);
----------------
Nit: maybe "are only supported on 64-bit targets"?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123496/new/

https://reviews.llvm.org/D123496



More information about the llvm-commits mailing list