[PATCH] D123496: Add Stackmap support for RISC-V

Alex Bradbury via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 13 08:33:50 PDT 2022


asb added a comment.

In D123496#3445710 <https://reviews.llvm.org/D123496#3445710>, @Zeavee wrote:

> Sorry for the delay, it took me some time to run `clang-format`. I also added the context as asked. Finally, I added an assert to make sure STACKMAP, PATCHPOINT and STATEPOINT are only used with RV64.

I'm not seeing the codepaths for the case where the intrinsics are used on RV32? You'll want to use `report_fatal_error` rather than `assert` (as the assert wont' be checked on release builds).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123496/new/

https://reviews.llvm.org/D123496



More information about the llvm-commits mailing list