[PATCH] D123669: [ArgPromotion] Use SmallSetVector to traverse values
Nikita Popov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Apr 13 07:07:21 PDT 2022
nikic requested changes to this revision.
nikic added a comment.
This revision now requires changes to proceed.
This doesn't make sense. The visited set must contain all visited instructions to prevent infinite loops. The worklist on the other hand only contains instructions yet to be visited. They are complement sets, you can't combine them into one, or at least not as implemented.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D123669/new/
https://reviews.llvm.org/D123669
More information about the llvm-commits
mailing list