[PATCH] D121984: [RISCV] Moving RVV intrinsic type related util to clang/Support

Aaron Ballman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 13 06:41:06 PDT 2022


aaron.ballman added a comment.

Errr, I'm not strongly opposed, but at the same time, this doesn't feel like a Support kind of thing. My understanding of llvm/Support is that it's primarily for generally useful utilities that are going to be used across the entire llvm project (or beyond). This is a very specific interface that's only interesting to TableGen as best I can tell. Why shouldn't this live in clang/utils/TableGen along with the others?



================
Comment at: clang/include/clang/Support/RISCVVIntrinsicUtils.h:1
+//===- RISCVVIntrinsicUtils.cpp - RISC-V Vector Intrinsic Utils -*- C++ -*-===//
+//
----------------
Comment here seems off (this isn't a .cpp file, it's a .h)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121984/new/

https://reviews.llvm.org/D121984



More information about the llvm-commits mailing list