[PATCH] D113399: [flang][OpenMP] Add semantic checks of nesting of region about ordered construct

[Kiran Chandramohan via Phabricator via llvm-commits]

kiranchandramohan accepted this revision.
kiranchandramohan added a comment.
This revision is now accepted and ready to land.

LGTM. Thanks @peixin and apologies for the long wait.



================
Comment at: flang/lib/Semantics/check-omp-structure.cpp:1110
+      llvm::omp::Directive::OMPD_target_parallel_do};
+  bool isNestedInDoOrderedWithPara = false;
+  if (CurrentDirectiveIsNested() &&
----------------
Nit: braced init.


================
Comment at: flang/lib/Semantics/check-omp-structure.cpp:1136
+    std::optional<std::int64_t> orderedValue) {
+  auto clauseAll = FindClauses(llvm::omp::Clause::OMPC_depend);
+  for (auto itr = clauseAll.first; itr != clauseAll.second; ++itr) {
----------------
Nit: Braced init if possible.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113399/new/

https://reviews.llvm.org/D113399