[PATCH] D123414: [AArch64] Break up larger shuffle-masks into legal sizes in getShuffleCost

Sam Tebbs via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 13 03:10:55 PDT 2022


samtebbs added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64TargetTransformInfo.cpp:2654
+          NumSources = 1;
+        } else if (NumSources == 1 && Source != Source1) {
+          Source2 = Source;
----------------
I might be misunderstanding this part of the code but I don't see how `Source != Source1` will ever be true, since `Source1` is assigned to `Source` when `NumSources == 0`, which is always the case in the first iteration. Same for the other else-if below.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123414/new/

https://reviews.llvm.org/D123414



More information about the llvm-commits mailing list