[PATCH] D123591: [LLD][COFF] Add support for /noimplib

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added inline comments.


================
Comment at: lld/COFF/Driver.cpp:1677
+  if (auto *arg = args.getLastArg(OPT_noimplib))
+    config->noimplib = true;
+
----------------
nikic wrote:
> nit: Variable `arg` is unused and causes a warning. Should this be using `arg->getValue()`?
I guess this should be `args.hasArg(OPT_noimplib)` instead.

@thieta, what happens if the user specifies `-noimplib -implib:otherfile.lib`? Does the last argument win (i.e. we should use `args.getLastArg(OPT_implib, OPT_noimplib)` and see which one was set last, or is it the case that `-noimplib` always trumps `-implib`, regardless of their respective ordering?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123591/new/

https://reviews.llvm.org/D123591