[PATCH] D123579: [RISCV][VP] Add RVV codegen for vp.trunc.

[Jianjian Guan via Phabricator via llvm-commits]

jacquesguan added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:3172
   }
   case ISD::TRUNCATE: {
     // Only custom-lower vector truncates
----------------
frasercrmck wrote:
> Can trim the unnecessary `{}` now too
Done.


================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:4352
 
   SplatOne = DAG.getNode(RISCVISD::VMV_V_X_VL, DL, ContainerVT,
                          DAG.getUNDEF(ContainerVT), SplatOne);
----------------
craig.topper wrote:
> Am I crazy or are these splats missing their VL operand?
I add the VL operand, I think it work without VL because those splat will finally match to vi instructions.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123579/new/

https://reviews.llvm.org/D123579