[PATCH] D123588: [InstCombine] fix tests in fneg.ll

Chenbing.Zheng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 12 19:23:26 PDT 2022


Chenbing.Zheng abandoned this revision.
Chenbing.Zheng added a comment.

In D123588#3445310 <https://reviews.llvm.org/D123588#3445310>, @spatel wrote:

> The TODO comment appears to be correct:
> https://alive2.llvm.org/ce/z/Vwtz9q
>
> So we should leave this test the same, but add another test that has 'nsz' on the select only?
> https://alive2.llvm.org/ce/z/r_fPEu
>
> If that sounds good, please commit an "NFC" patch to add one more test (no review on Phabricator is needed to add a test unless there are still open questions).

Thanks for your explanation. I agree with you.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123588/new/

https://reviews.llvm.org/D123588



More information about the llvm-commits mailing list