[PATCH] D123400: [LoopCacheAnalysis] Consider dimension depth of the subscript reference when calculating cost

[Ehsan Amiri via Phabricator via llvm-commits]

amehsan added a comment.

In D123400#3443913 <https://reviews.llvm.org/D123400#3443913>, @bmahjour wrote:

> I explained my reasoning for needing a different approach in D122776 <https://reviews.llvm.org/D122776>. I just figured it would be a lot easier to show what I mean by posting a new patch instead of trying to describe it as a change request on top of D122776 <https://reviews.llvm.org/D122776>. I'm happy to continue further discussion on this wherever seems more appropriate to you or other reviewers.

Thanks Bardia….Since this patch already has a LGTM, perhaps the easiest thing is to merge this.  Just to clarify my comment, first I want to appreciate your input to the discussions and your effort in reviewing the patches, looking into papers and in general feedback that you provide. I think it is more encouraging if we avoid creating parallel patches, once a patch is under discussion, to recognize the effort that has gone into identifying the problem, investigating different solutions, and creating the initial patch. That does not mean to imply that reviewing the patch is an easy task and in some cases like what you have done, it involves reading a paper, or some other significant contribution. But as long as the author of original patch is active and receptive to feedback I don’t see a reason for parallel patches. I am open to alternative opinions from others.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123400/new/

https://reviews.llvm.org/D123400