[PATCH] D122251: [lit] Use sharding for GoogleTest format

[Yuanfang Chen via Phabricator via llvm-commits]

ychen added a comment.

In D122251#3446870 <https://reviews.llvm.org/D122251#3446870>, @rprichard wrote:

> I think this change broke libc++ tests. `_executeScriptInternal` in libcxx/utils/libcxx/test/dsl.py does not pass an argument for LitConfig's new `order` parameter:
>
>   rprichard at cashew:/x/llvm-upstream/out$ cmake -GNinja -S ../llvm-project/runtimes -DLLVM_ENABLE_RUNTIMES="libcxx;libcxxabi;libunwind" -DLIBCXXABI_USE_LLVM_UNWINDER=ON
>   ...
>   rprichard at cashew:/x/llvm-upstream/out$ ninja
>   ...
>   rprichard at cashew:/x/llvm-upstream/out$ ninja check-cxx
>   [0/1] Running libcxx tests
>   llvm-lit: /x/llvm-upstream/llvm-project/libcxx/utils/libcxx/test/newconfig.py:23: note: Applied 'add Lit feature target=x86_64-unknown-linux-gnu' as a result of parameter 'target_triple=x86_64-unknown-linux-gnu'
>   llvm-lit: /x/llvm-upstream/llvm-project/llvm/utils/lit/lit/TestingConfig.py:103: fatal: unable to parse config file '/x/llvm-upstream/out/libcxx/test/lit.site.cfg', traceback: Traceback (most recent call last):
>     File "/x/llvm-upstream/llvm-project/llvm/utils/lit/lit/TestingConfig.py", line 92, in load_from_path
>       exec(compile(data, path, 'exec'), cfg_globals, None)
>     File "/x/llvm-upstream/out/libcxx/test/lit.site.cfg", line 21, in <module>
>       libcxx.test.newconfig.configure(
>     File "/x/llvm-upstream/llvm-project/libcxx/utils/libcxx/test/newconfig.py", line 22, in configure
>       action.applyTo(config)
>     File "/x/llvm-upstream/llvm-project/libcxx/utils/libcxx/test/dsl.py", line 400, in applyTo
>       if hasCompileFlag(config, flag):
>     File "/x/llvm-upstream/llvm-project/libcxx/utils/libcxx/test/dsl.py", line 64, in f
>       cache[cacheKey] = function(config, *args, **kwargs)
>     File "/x/llvm-upstream/llvm-project/libcxx/utils/libcxx/test/dsl.py", line 203, in hasCompileFlag
>       out, err, exitCode, timeoutInfo = _executeScriptInternal(test, [
>     File "/x/llvm-upstream/llvm-project/libcxx/utils/libcxx/test/dsl.py", line 80, in _executeScriptInternal
>       litConfig = lit.LitConfig.LitConfig(
>   TypeError: __init__() missing 1 required positional argument: 'order'
>   
>   FAILED: libcxx/test/CMakeFiles/check-cxx /x/llvm-upstream/out/libcxx/test/CMakeFiles/check-cxx 
>   cd /x/llvm-upstream/out/libcxx/test && /usr/bin/python3.9 /x/llvm-upstream/out/bin/llvm-lit -sv --show-xfail --show-unsupported /x/llvm-upstream/out/libcxx/test
>   ninja: build stopped: subcommand failed.

Fixed in 81b51b61f849fa91bdf5d069591 <https://reviews.llvm.org/rG81b51b61f849fa91bdf5d0695918578abae846e3>


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122251/new/

https://reviews.llvm.org/D122251