[PATCH] D122569: [lit] Support %if ... %else syntax for RUN lines
Alexander Richardson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Apr 12 15:36:22 PDT 2022
arichardson added a comment.
In D122569#3442909 <https://reviews.llvm.org/D122569#3442909>, @asavonic wrote:
> In D122569#3441717 <https://reviews.llvm.org/D122569#3441717>, @lebedev.ri wrote:
>
>> Please don't forget to also update the `llvm/utils/update_*_checks.py`.
>
> It seems that update_*_checks.py scripts are completely independent of lit.py, so there is no way to easily reuse code between them. Parsing of RUN lines and standard substitutions is duplicated there. We have to either integrate these scripts, or copy paste the code.
I had some code in the downstream CHERI LLVM to expand substitutions using lit. The downside is that the update scripts need to know the path to the build dir to get all the lit config files, but if there is interest I'd be happy to upstream that change.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D122569/new/
https://reviews.llvm.org/D122569
More information about the llvm-commits
mailing list