[PATCH] D122939: [NVPTX][tests] Do not run the test CodeGen/Generic/2010-11-04-BigByval.ll

Tue Apr 12 12:21:32 PDT 2022

tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.

This is odd. `nvptx-registered-target` is present among the features and  (I think) should have been matched by `UNSUPPORTED: nvptx`.
Documentation says that UNSUPPORTED matches `Substrings of the target triple` and I assumed that would be the case for the feature matches, too, but, apparently that's not the case.

So, it appears that your observation that `UNSUPPORTED: nvptx` does what we want is correct. It ends up matching the target triple only.

LGTM.

================
Comment at: llvm/test/CodeGen/Generic/2010-11-04-BigByval.ll:4

+; Please note, that there are NVPTX special testcases for "byval"
+; UNSUPPORTED: nvptx
----------------
Please also mention that the test is intentionally disabled only for the NVPTX target  (i.e. not for `nvptx-registered-target` feature) due to excessive runtime.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122939/new/

https://reviews.llvm.org/D122939