[PATCH] D123602: [MSan] Ensure argument shadow initialized on memcpy

Evgenii Stepanov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 12 11:31:55 PDT 2022


eugenis accepted this revision.
eugenis added a comment.

Could you clarify that the problem is specifically with byval argument in the patch description?

Also, I'm wondering if we should make this copy explicit, perhaps by checking if the argument has any uses in the function body. I'm not 100% convinced that this is the only place where we forget to copy the shadow.

This change LGTM as a quick fix.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123602/new/

https://reviews.llvm.org/D123602



More information about the llvm-commits mailing list