[PATCH] D123548: AMDGPU: Emit metadata for the hidden_multigrid_sync_arg conditionally

[Changpeng Fang via Phabricator via llvm-commits]

cfang added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUAttributor.cpp:439
 
+    if (funcRetrievesMultigridSyncArg(A)) {
+      assert(!isAssumed(IMPLICIT_ARG_PTR) &&
----------------
arsenm wrote:
> Since we're going to start adding a lot of these, should we do checks for all the different fields in one forallInterferingAccesses call?
This is a good suggestion. But I would rather postpone it to another patch.
I need time to investigate all the possible complexities we might encounter.
For example, two arguments shares the same offset in the same code object version, one argument has different offsets for different code object versions.
I also need to understand how to do all checks in one call. 
 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123548/new/

https://reviews.llvm.org/D123548