[PATCH] D108363: [AMDGPU] Propagate !noalias and !alias.scope metadata in AMDGPULowerKernelArguments for noalias arguments.

Abinav Puthan Purayil via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 12 10:10:30 PDT 2022


abinavpp added a comment.

In D108363#3444601 <https://reviews.llvm.org/D108363#3444601>, @abinavpp wrote:

> In D108363#3442578 <https://reviews.llvm.org/D108363#3442578>, @arsenm wrote:
>
>> In D108363#2961903 <https://reviews.llvm.org/D108363#2961903>, @abinavpp wrote:
>>
>>> In D108363#2960892 <https://reviews.llvm.org/D108363#2960892>, @arsenm wrote:
>>>
>>>> Same purpose as D105721 <https://reviews.llvm.org/D105721>?
>>>
>>> Oh! I didn't notice that. @hliao , how should we move forward? Should we abandon this and https://reviews.llvm.org/D108361, or keep https://reviews.llvm.org/D108361 and use it for https://reviews.llvm.org/D105721?
>>
>> Ping. Was there any discussion of which way is better?
>
> No, sorry. @hliao what do you think?
>
> I'll check this patch with PSDB.

PSDB's result of this patch with D108361 <https://reviews.llvm.org/D108361> is a conditional go.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108363/new/

https://reviews.llvm.org/D108363



More information about the llvm-commits mailing list