[PATCH] D115620: [AArch64] Lowering and legalization of strict FP16

John Brawn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 12 09:24:08 PDT 2022


john.brawn added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:1386
+
+  IsStrictFPEnabled = true;
 }
----------------
dmgreen wrote:
> What are the ramifications of setting this to true?
The behaviour with IsStrictFPEnabled = false is that strict fp nodes are mutated into their non-strict equivalent at the start of ISel (in SelectionDAGISel::DoInstructionSelection). Setting it to true means that this mutation doesn't happen, so strict nodes are preserved all the way through to the actual instruction selection.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115620/new/

https://reviews.llvm.org/D115620



More information about the llvm-commits mailing list