[PATCH] D123461: [AMDGPU][Codegen] Unsupported image sample texture map instructions

Dmitry Preobrazhensky via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 12 09:14:58 PDT 2022


dp accepted this revision.
dp added a comment.
This revision is now accepted and ready to land.

LGTM except for a minor typo



================
Comment at: llvm/lib/Target/AMDGPU/MIMGInstructions.td:1086
 defm IMAGE_SAMPLE_C_CD_CL_O_G16 : MIMG_Sampler <mimgopc<0xef>, AMDGPUSample_c_cd_cl_o, 0, 1>;
-} // End OtherPredicates = [HasExtendedImageInsts]
+} // End OtherPredicates = [HasExtendedImageInsts,isGFX10PLUS]
+
----------------
This should be updated as well


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123461/new/

https://reviews.llvm.org/D123461



More information about the llvm-commits mailing list