[PATCH] D123181: [RISCV] Refactoring the type promotion process of instructions fsl/fsr

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 12 09:09:47 PDT 2022

Previous message: [PATCH] D123181: [RISCV] Refactoring the type promotion process of instructions fsl/fsr
Next message: [PATCH] D123486: [InstCombine] fold more constant remainder to select-of-constants remainder
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

craig.topper added a comment.

LGTM, but please update the commit title since you also changed becompress, bdecompress and bfp.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123181/new/

https://reviews.llvm.org/D123181

Previous message: [PATCH] D123181: [RISCV] Refactoring the type promotion process of instructions fsl/fsr
Next message: [PATCH] D123486: [InstCombine] fold more constant remainder to select-of-constants remainder
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the llvm-commits mailing list