[PATCH] D123467: [NFC][CodeGen] Use ArrayRef in TargetLowering functions

Shao-Ce SUN via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 12 08:57:28 PDT 2022


sunshaoce added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/TargetLowering.h:2259
+  }
+  void setOperationAction(ArrayRef<unsigned> Ops, ArrayRef<MVT> VTs,
+                          LegalizeAction Action) {
----------------
craig.topper wrote:
> Can't we have ArrayRef for both operands and use 2 for loops. Why do we need two functions?
  llvm-project/llvm/lib/CodeGen/TargetLoweringBase.cpp:844:37: error: no viable conversion from 'llvm::MVT::SimpleValueType' to 'ArrayRef<llvm::MVT>'
  setOperationAction(ISD::PREFETCH, MVT::Other, Expand);
It doesn't seem possible to convert both `MVT` to `ArrayRef<MVT>` at the same time, any better idea?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123467/new/

https://reviews.llvm.org/D123467



More information about the llvm-commits mailing list