[llvm] 0488c66 - [X86] getFauxShuffleMask - remove use DemandedElts TODO

Simon Pilgrim via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 12 07:36:46 PDT 2022


Author: Simon Pilgrim
Date: 2022-04-12T15:36:30+01:00
New Revision: 0488c6638bfe7db41a11a010542337fcac180521

URL: https://github.com/llvm/llvm-project/commit/0488c6638bfe7db41a11a010542337fcac180521
DIFF: https://github.com/llvm/llvm-project/commit/0488c6638bfe7db41a11a010542337fcac180521.diff

LOG: [X86] getFauxShuffleMask - remove use DemandedElts TODO

Most of the getTargetShuffleInputs recursive calls have now gone and the remaining uses aren't likely to benefit from a DemandedElts mask

Added: 
    

Modified: 
    llvm/lib/Target/X86/X86ISelLowering.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Target/X86/X86ISelLowering.cpp b/llvm/lib/Target/X86/X86ISelLowering.cpp
index d74a8e72bbe89..a1b3c5b1ab57c 100644
--- a/llvm/lib/Target/X86/X86ISelLowering.cpp
+++ b/llvm/lib/Target/X86/X86ISelLowering.cpp
@@ -7976,7 +7976,6 @@ static void resolveZeroablesFromTargetShuffle(const SmallVectorImpl<int> &Mask,
 }
 
 // Forward declaration (for getFauxShuffleMask recursive check).
-// TODO: Use DemandedElts variant.
 static bool getTargetShuffleInputs(SDValue Op, SmallVectorImpl<SDValue> &Inputs,
                                    SmallVectorImpl<int> &Mask,
                                    const SelectionDAG &DAG, unsigned Depth,


        


More information about the llvm-commits mailing list