[PATCH] D123516: Fix SLP score for out of order contiguous loads

Vasileios Porpodas via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 12 06:51:29 PDT 2022


vporpo added inline comments.


================
Comment at: llvm/test/Transforms/SLPVectorizer/AArch64/tsc-s116.ll:17-23
+entry:
+  br label %for.body
+
+for.cond.cleanup:                                 ; preds = %for.body
+  ret void
+
+for.body:                                         ; preds = %entry, %for.body
----------------
This test should work fine without the loop and the `entry` and `for.cond.cleanup` blocks.  Please remove these extra blocks and the loop-related code.


================
Comment at: llvm/test/Transforms/SLPVectorizer/AArch64/tsc-s116.ll:25-28
+  %offset_1 = or i64 %indvars.iv, 1
+  %offset_2 = or i64 %indvars.iv, 2
+  %offset_3 = or i64 %indvars.iv, 3
+  %indvars.iv.next = add nuw nsw i64 %indvars.iv, 4
----------------
Do you think you could replace these offset calculations with constants? This would make the test a lot smaller. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123516/new/

https://reviews.llvm.org/D123516



More information about the llvm-commits mailing list